Skip to content

helper to generate auto publication workflows#13581

Merged
svgeesus merged 4 commits intomainfrom
auto-publish-workflows-generator
Mar 3, 2026
Merged

helper to generate auto publication workflows#13581
svgeesus merged 4 commits intomainfrom
auto-publish-workflows-generator

Conversation

@deniak
Copy link
Member

@deniak deniak commented Mar 2, 2026

Based on @tidoust's suggestion, that PR adds a script to help generate the auto publication workflows for a given list of specs.
That PR assumes that the source document is named Overview.bs and each folder matches the shortname of the spec.

@deniak deniak requested a review from svgeesus March 2, 2026 07:08
Co-authored-by: François Daoust <fd@tidoust.net>
@svgeesus
Copy link
Contributor

svgeesus commented Mar 3, 2026

I see a failing check, but don't understand it. @deniak @tidoust

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general and easier to maintain

@svgeesus svgeesus merged commit 81b669c into main Mar 3, 2026
3 of 4 checks passed
@svgeesus svgeesus deleted the auto-publish-workflows-generator branch March 3, 2026 20:57
@svgeesus
Copy link
Contributor

svgeesus commented Mar 3, 2026

So, now that this is merged, what triggers the python script to run? Or do we run it locally and just commit the results?

@deniak
Copy link
Member Author

deniak commented Mar 4, 2026

So, now that this is merged, what triggers the python script to run? Or do we run it locally and just commit the results?

The script needs to be run manually only when there's a new spec to be autopublished or if the template is updated.

@deniak
Copy link
Member Author

deniak commented Mar 4, 2026

I see a failing check, but don't understand it. @deniak @tidoust

I see the recent checks passed. Please provide a link to the error if I missed something.

@svgeesus
Copy link
Contributor

svgeesus commented Mar 5, 2026

I see the recent checks passed. Please provide a link to the error if I missed something.

It is because Bikeshed warnings prevent publication. Bikeshed warns on variables only used once. I had been ignoring that because bikeshed is wrong (it does not consider foo and foo[2] to be two uses of foo but I changed the spec to prevent the warning and now it auto-publishes correctly.

@tabatkins
Copy link
Member

(it does not consider foo and foo[2] to be two uses of foo

Since spec variables are in no particular language, there is no way for me to tell what part of the contents of a <var> are the "name" and what parts are "other stuff". So I'm as right as possible here. If you want it to work "correctly", <code>|foo|[2]</code> to just mark up the intended variable name as the var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants